From d19689af33204e19f2849a0fa4ba3cd05e9eee64 Mon Sep 17 00:00:00 2001 From: kentdr Date: Thu, 14 Sep 2023 11:50:07 -0400 Subject: [PATCH] Obsolete the PreObsoletes --- .../SagaPersisters/CompatibilitySettings.cs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/NServiceBus.Persistence.AzureTable/SagaPersisters/CompatibilitySettings.cs b/src/NServiceBus.Persistence.AzureTable/SagaPersisters/CompatibilitySettings.cs index 210ff245..80863ed3 100644 --- a/src/NServiceBus.Persistence.AzureTable/SagaPersisters/CompatibilitySettings.cs +++ b/src/NServiceBus.Persistence.AzureTable/SagaPersisters/CompatibilitySettings.cs @@ -19,8 +19,7 @@ internal CompatibilitySettings(SettingsHolder settings) : base(settings) /// Once all sagas have been migrated from version 2.4.x of the persister to the current version the lookup can be disabled no longer calling this method. /// All migrated sagas do not contain a row called NServiceBus_2ndIndexKey /// - [PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836", - Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")] + [ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")] public void EnableSecondaryKeyLookupForSagasCorrelatedByProperties() { var settings = this.GetSettings(); @@ -31,7 +30,7 @@ public void EnableSecondaryKeyLookupForSagasCorrelatedByProperties() /// Opt-in to full table scanning for sagas that have been stored with version 1.4 or earlier. /// /// Enabling this also requires enabling the compatibility mode by calling - [PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836", Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")] + [ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")] public void AllowSecondaryKeyLookupToFallbackToFullTableScan() { var settings = this.GetSettings(); @@ -49,7 +48,7 @@ public void AllowSecondaryKeyLookupToFallbackToFullTableScan() /// ensure all secondary index entries use RowKey = PartitionKey. By enabling this setting the secondary key lookups will assume RowKey = PartitionKey. /// /// Enabling this also requires enabling the compatibility mode by calling - [PreObsolete("https://github.com/Particular/NServiceBus.Persistence.AzureTable/issues/836", Note = "Following our breaking change guidelines, the compatibility mode should be removed at some point after making it opt-in.")] + [ObsoleteEx(Message = "Compatibility mode is deprecated and will be removed in future versions.", RemoveInVersion = "8.0", TreatAsErrorFromVersion = "7.0")] public void AssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey() { var settings = this.GetSettings(); @@ -62,4 +61,4 @@ public void AssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey() settings.Set(WellKnownConfigurationKeys.SagaStorageAssumeSecondaryKeyUsesANonEmptyRowKeySetToThePartitionKey, true); } } -} \ No newline at end of file +}