Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Prepare modules for implementation of ForgeHooks and co. #121

Closed
wants to merge 7 commits into from

Conversation

kitlith
Copy link
Contributor

@kitlith kitlith commented Jul 11, 2020

Required for #115. No, this isn't finished, but I figure getting a PR open before I go sleep makes it easier for other people to comment/review what I'm doing.

a note: Glitch said these classes should be named PatchworkEvents, but I went with Events as that was the pre-existing style. I can do a commit to refactor these cases into PatchworkEvents though, so lmk if you'd like me to do that.

Each commit should handle a module, and should be able to be looked at individually.

@kitlith kitlith requested a review from TheGlitch76 July 11, 2020 07:29
@kitlith
Copy link
Contributor Author

kitlith commented Jul 11, 2020

okay, that's all the events I found that are called in ForgeHooks, and similar at least. not all of ForgeHooks is sending events though. (i.e. ForgeHooks.canHarvestBlock)

I'm also somewhat dubious about that last commit with patchwork-gui, since those event aren't fired yet, but I decided to go for it since the classes were already present (unlike other methods that I avoided adding because the class was commented out)

@kitlith
Copy link
Contributor Author

kitlith commented Jul 13, 2020

I'm splitting this into seperate PRs.

@kitlith kitlith removed the request for review from TheGlitch76 July 14, 2020 00:02
@kitlith kitlith closed this Jul 17, 2020
@kitlith kitlith deleted the patchworkXevents branch July 17, 2020 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant