Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Table Structuring - Part 1 #530

Closed
6 tasks done
CollinHerber opened this issue Dec 3, 2024 · 0 comments · Fixed by #550
Closed
6 tasks done

Drop Table Structuring - Part 1 #530

CollinHerber opened this issue Dec 3, 2024 · 0 comments · Fixed by #550
Assignees
Labels
enhancement New feature or request ready When a ticket is ready to be worked
Milestone

Comments

@CollinHerber
Copy link
Collaborator

CollinHerber commented Dec 3, 2024

Summary

Expanding on the discussion here: #486
This ticket will serve as the part 1 re-adjustments for the drop tables.

Major Changes

Items that are dropped from mobs will no longer drop normal rarity.

The reason for this is with ARPGs you drop a ton of items, including a ton of normal items. Then you basically get to pick what you want up off the ground. However in terraria you pickup everything nearby so to counter this we are just going to make drops a bit more rare, while also making the likely irrelevant drops completely gone. IE the normal drops. Items can still be made normal through crafting however, and normal items may still be offered in NPC Shops

Tasks

  • Create a ItemDropper (or something similar) class that we can use to consolidate item dropping logic
  • Update the logic to be a bit easier to read. Use private consts in the class scope with "Base Drop Percent" and such so easier adjustments can be made. Just so it's not just numbers thrown into the logic
  • Remove normal rarity from being available in the drops
  • 85% Magic Chance - 15% Rare Chance

NOTE: Do not change drop chances as apart of this effort. We'll adjust in other areas

Adjusting the drop rates dynamically

We want the area level the player is in to effect the drop percent chances. This means that with each boss domain completed items should become more frequent. Monsters get harder, and the player should get more loot the more they progress.

Refer to the table here: https://wiki.pathofterraria.com/en/Drops on the area level and drop chances that should be taken into account.

Tasks
- [ ] Add Logic to ItemDropper Class to dynamically have drop chances based on the area level
Decided to skip for now

Adding in Currency Drops & Item Type Drop Chances

In order to unlock currency crafting for players we need to introduce currencies in drops. Item types will all have their own drop chances when the mod says "Drop a PoT Item". So the OnKill should say "Drop a PoT Item" and that calls the ItemDropper , and then all the logic is handled there.

Tasks

  • When the ItemDropper class says that an item will be dropped, then pick a type (90% Gear, 8% Currency, 2% Map)
  • Once a type is figured out now drop an item that matches that type using the normal rarity selection

Reasonings

Make Drops Great

@CollinHerber CollinHerber added enhancement New feature or request ready When a ticket is ready to be worked labels Dec 3, 2024
@CollinHerber CollinHerber added this to the Play Test milestone Dec 3, 2024
@CollinHerber CollinHerber self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready When a ticket is ready to be worked
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant