Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biopax_to_factoid: /biopax-url-to-json format, grounding in response #14

Open
jvwong opened this issue Oct 16, 2020 · 2 comments
Open

Comments

@jvwong
Copy link
Member

jvwong commented Oct 16, 2020

Regarding the endpoint /biopax-url-to-json

  1. Could you indicate (swagger) what format you are expecting when the url is retrieved? I suspect it's not BioPAX owl, application/xml but a tar.gz file?

  2. grounding: I don't believe this makes its way into the JSON response for bioentities. Ideally biofactoid would want NCBI Gene uids, but I realize there might be some mapping required for that.

@IgorRodchenkov
Copy link
Member

@metincansiper , @jvwong
There is code
public String biopaxUrlToFactoid( @ApiParam("URL of a BioPAX RDF/XML file") @RequestBody String url) { BiopaxToFactoid converter = new BiopaxToFactoid(); try { String body = getContentFromUrl(url); InputStream is = new ByteArrayInputStream(body.getBytes(StandardCharsets.UTF_8));

which I doubt it works - it is read the URL string itself instead of the remote file/content I bet
Why @RequestBody String url ? (not @RequestParam String url)
Are you really sending the URL as the request body content instead of using some JSON object or query parameter?
(Sorry if I am missing something - long time not looking here ;)))

metincansiper added a commit that referenced this issue Mar 23, 2021
…ed in #14. Updated some comments. Added pc2.owl file to gitignore.
@metincansiper
Copy link
Collaborator

@jvwong I updated the api description. I think we resolved the grounding issue in another thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants