Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle program differently in case of an exception #120

Closed
markkvdb opened this issue Oct 27, 2020 · 3 comments
Closed

Handle program differently in case of an exception #120

markkvdb opened this issue Oct 27, 2020 · 3 comments

Comments

@markkvdb
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

JobFunnel crashes when an exception occurs during scraping because a page cannot be reached due to a CAPTCHA or network error. However, sometimes hundreds of job listings have been scraped so far.

Describe the solution you'd like

Save job listings that have been scraped so far instead of exiting the program with an exception. This could also be implemented for a KeyboardInterrupt.

@PaulMcInnis
Copy link
Owner

👍 We should definitely have better exception handling, Currently we capture a limited number of issues.

@thebigG
Copy link
Collaborator

thebigG commented Dec 31, 2020

Just wanted to add a quick note:this will also fix the issues we are having in the CI pipeline right now. Indeed has been doing this a lot with CAPTCHA lately.

@PaulMcInnis
Copy link
Owner

closing due to inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants