Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove brotli encoding #139

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

marchbnr
Copy link
Contributor

Remove brotli compression from accepted encodings for indeed sessions

Description

Resolves an issue related with the indeed scraper where the responses are not decoded correctly.
Brotli support can be added again if the brotli package is added to the dependencies.

Context of change

Please add options that are relevant and mark any boxes that apply.

  • Software (software that runs on the PC)
  • Library (library that runs on the PC)
  • Tool (tool that assists coding development)
  • Other

Type of change

Please mark any boxes that apply.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Only tested locally so far. Unit tests still run through.

Checklist:

Please mark any boxes that have been completed.

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Resolves an issue where indeed responses are not being decoded correctly.
Might resolve issue PaulMcInnis#137
@marchbnr marchbnr force-pushed the remove-brotli-encoding branch from 2128be1 to 4182985 Compare March 29, 2021 10:39
@marchbnr
Copy link
Contributor Author

This might also be a macos specific issue. My specs:
ProductName: macOS
ProductVersion: 11.2
BuildVersion: 20D64

Copy link
Owner

@PaulMcInnis PaulMcInnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving since I see no issue with making this change given that the PR-triggered tests pass.

@PaulMcInnis PaulMcInnis linked an issue Mar 29, 2021 that may be closed by this pull request
@PaulMcInnis PaulMcInnis merged commit 05e7712 into PaulMcInnis:master Mar 29, 2021
@PaulMcInnis
Copy link
Owner

Merging this since it seems to fix the massive issues with existing release.

Thanks for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobFunnel: Failed to scrape jobs for IndeedScraperUSAEng
2 participants