Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be nice to have a way to disable false-positives #18

Open
jeanraymonddaher opened this issue Dec 6, 2018 · 1 comment · May be fixed by #32
Open

It would be nice to have a way to disable false-positives #18

jeanraymonddaher opened this issue Dec 6, 2018 · 1 comment · May be fixed by #32

Comments

@jeanraymonddaher
Copy link

The script is currently very useful since its well maintained, does the job and is extremely simple to integrate.

You could add this to the installation
1- Place the file inside your project folder directory
2- Call it via $SRCROOT/unused.rb xcode

Given that there are a lot of false positives like mentioning the word protocol in a comment or others, it would be nice to have a way like swift-lint to disable specific warnings.

ex unused-disable-this which would disable the warning on the specific line
unused-disable-all which would disable warnings for all the class

What do you think about it ?

Awesome project btw

@PaulTaykalo
Copy link
Owner

@PaulTaykalo I don't think that this needs to be done if we take in account, how this check is implemented.
I don't want to build a castle on the sand :)

The way how is it implemented, doesn't actually work at big scale.
I would rather transition to some SourceKit/SwiftSyntax solution.
But, unfortuneately, there's no time for that ATM :)

If you have solution that will work, I don't mind from having a PR for that :)

@agarrharr agarrharr linked a pull request Oct 31, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants