Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script: patch_shpc_pawsey_modules.sh is being called twice #239

Open
AlexisEspinosaGayosso opened this issue Oct 30, 2023 · 0 comments
Open

Comments

@AlexisEspinosaGayosso
Copy link
Contributor

Script: "patch_shpc_pawsey_modules.sh" is being called twice:

  1. From parent script: "install_shpc_containers.sh" (final line)
  2. From parent script: "post_installation_operations.sh" (final line)

We need to decide from where to call it (one or the other). Personally, I prefer to call it from the 1st parent script, as this makes a bit more clear what are the steps performed for the shpc containers. But I will leave the decision to the repo maintainers, as 2nd parent script may have been designed to perform these kinds of operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant