Version 2: Add stylistic Eslint #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update vite to latest * Update react to latest * Change app structure * Add ThemeProvider * Add FetchingStatusOwerlay component * Add i18n * Add CertificatesProvidersList * Add clsx & scss * Add theme colors * Add table's components * Components refactoring * Rename app providers component * Add CertificatesList component * add post css & autoprefixer * add postcss config * Add Certificates Layout * Improve app sidebar * Fix theme * Refactor app structure * Add vite-plugin-svgr * Add vite-plugin-svgr types * Add --pv-border-radius-base * Style providers list component * Fix contact suport url * Add ESLint & Prettier * Add empty state to CertificatesList * Add empty state to CertificatesProvidersList * Fix body font-family duplication * Rename getCertificatesByProviderId to handleProviderChange * Remove i18next-icu * Improve CertificatesProvidersList accessibility * Use Typography in CertificatesProvidersListItem * Local imports should be at the very bottom * Let's make options non-optional in CertificatesProvidersListItem * Don't use object destructuring in function arguments * Let's remove commented code in App component * Use Typography in CertificatesList empty state * Let's make options non-optional in CertificatesList * Add sticky filters and sticky table header * Table missed type icon identifier * Add actions menu to CertificatesList * Change build dir * Add Date component * Add CertificateName component * Add CertificateSerialNumber component * Fix CertificatesProvidersList labels * Fix sidebar footer labels * Fix CertificatesProvidersList items gap & selected bg * Truncate long provider name * Fix providers list scroll * Remove optional from providers prop * FetchingStatusOwerlay refactoring * Improve table row shadow * Update packages * The table header and body text are not aligned vertically * Fix sidebar contact box size * Row table text is not aligned horizontally * The certificates list table has not equal padding * Fix providers list scrollbar * Add CertificatesTopbar --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
* Add CertificateViewer * Fix certificate viewer dialog width * Fix certificate viewer dialog content padding * Make certificate prop as required dependency in CertificateViewerDialog * Fix certificate viewer dialog width --------- Co-authored-by: alex-slobodian <[email protected]>
* Add styles to FetchingStatusOwerlay * Fix FetchingStatus dialog width --------- Co-authored-by: alex-slobodian <[email protected]>
* Create CertificateDeleteButton component * Create CertificateDeleteButton component * Create CertificateDeleteDialog * Add delete dialog to certificates list * Fix after merge * Improve Delete button in certificates list * Improve CertificateDeleteDialog * Fix CertificatesList action menu items gap * Fix CertificateDeleteDialog loading state * Fix CertificateDeleteDialog title * Improve accessibility for CertificatesList * Fix naming --------- Co-authored-by: alex-slobodian <[email protected]>
* Add Certificate creation menu * Fix types --------- Co-authored-by: alex-slobodian <[email protected]>
* Add Certificate download button * Fix file name * Fix downloadCertificate * Use downloadFromBuffer method * Fix downloadCertificate --------- Co-authored-by: alex-slobodian <[email protected]>
* Add Copy button component * Fix Copy button component * Add copyCertificate method * Fix naming * Add copy button to list --------- Co-authored-by: alex-slobodian <[email protected]>
* Add vitest * fix vite config * Fix config --------- Co-authored-by: alex-slobodian <[email protected]>
* Add ci * Fix ci * setup-node * Fix setup-node * chore(ci): enable caching --------- Co-authored-by: alex-slobodian <[email protected]> Co-authored-by: donskov <[email protected]>
* Add CertificatesProvidersSelectList component * Add CertificateImportDialog component * Certificate Import Dialog open/close * Add file drop zone * Styles drop zone * Certificate processing * Fix certificate processing * Add actions * Fix title border * Fix styles * Fix drop zone styles & behaviour * Fix styles * Fix dialog title * Fix CertificatesProvidersSelectList style * Add useCertificateImportDialog * Fix provider selection * Fix provider select popover * Fix upload certificate * Lock fix --------- Co-authored-by: alex-slobodian <[email protected]>
* Improve providers list accessibility * Add loading skeleton * Add loading to app --------- Co-authored-by: alex-slobodian <[email protected]>
* Add CertificateTypeSelect component * Add KeyUsagesCheckboxGroup component * Add CountrySelect component * Fix naming * Add CertificateKeyPropertiesSelect * Add CertificateCreateDialog layout * Add CertificateTypeSelect to dialog * Fix CertificateTypeSelect * Add type selection * Add Card component * Add CertificateCreateByEmail block * Fix text field requrid styles * Add CertificateCreateByCname block * Add CertificateAlgorithmInfo component * Add CertificateCreateByCustom component * Add more fields CertificateCreateByCustom component * Add CertificateCreateByCustom to CertificateCreateDialog * Add useCertificateCreateDialog * Fix useCertificateCreateDialog * Fix useCertificateCreateDialog * Fix useCertificateCreateDialog * Fix dialog content width * Add create dialog to app * Fix Certificate Algorithm * Add type onCreate * Fix types * Add certificateSubjectToString method * Fix scroll in provider list * Fix overscroll behavior * Add scroll lock for import & create dialogs * Fix certificateKeyUsageExtensions * Fix form * Fix CertificateTypeSelect styles * Fix CertificateCreateDialog * Fix forms & validations * Fix CertificateCreateByCname * Fix CertificateCreateByEmail * Fix CertificateCreateByCustom * Fix ExtendedKeyUsages --------- Co-authored-by: alex-slobodian <[email protected]>
* Add useCertificateDeleteDialog * Fix Certificate Delete Dialog --------- Co-authored-by: alex-slobodian <[email protected]>
* Add app error boundary * Fix sorting of imports * Move to react-error-boundary package --------- Co-authored-by: alex-slobodian <[email protected]>
* Add CertificatesSidebar stories * Add CertificateName stories * Add CertificateSerialNumber stories * Add CertificateTypeLabel stories * Add Date stories --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
* Add SortButton component * Add sorting to certificate list * Fix sort title direction change * Fix sort button focus * Fix sort button focus * Add serch params for sorting * Fix SortButton disabled --------- Co-authored-by: alex-slobodian <[email protected]>
* Add certificate creation logic * Fixed useCertificateCreateDialog * Fix set ProviderId * Fix algorithm props * Fix algorithm props --------- Co-authored-by: alex-slobodian <[email protected]>
* Remove certificate logic * Rewfactoring useCertificateDeleteDialog * Fix handleOpen * Add list refresh after remove * Fix dialog render --------- Co-authored-by: alex-slobodian <[email protected]>
* Add HighlightedText component * Add highlight to CertificateName * Add highlighted text for certificate name in CertificatesList * Add CertificatesListLoading * Add CertificatesListLoading * Add Empty Search to CertificatesList --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
* Fix Certificate Import Dialog * Improve certificate converter * Delete extra convertation --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
* Add certificate search logic * Fix useSearch * Fix search input * Fix search input state --------- Co-authored-by: alex-slobodian <[email protected]>
* Update storybook * Update vite * Update vitest * Update vitest coverage * Update i18next * Update postcss & sass * Update prettier * Update typescript & eslint * Update @peculiar/react-components --------- Co-authored-by: alex-slobodian <[email protected]>
* Add certificate viewer dialog hook * Merge branch 'donskov/v2' into aslobodian/v2-certificate-viewer-dialog-hook * Merge branch 'donskov/v2' into aslobodian/v2-certificate-viewer-dialog-hook * Fix CertificatesList loading --------- Co-authored-by: alex-slobodian <[email protected]>
* Fix certificate name (label) * Fix search * Fix CertificateViewerDialog title * Fix certificateName for list actions --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
* Fix readme logo * Fix readme logo --------- Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
Co-authored-by: alex-slobodian <[email protected]>
|
@donskov We can add https://github.com/antfu/eslint-plugin-import-x in this PR too. Or will add this later in separate PR because there will be to many changes. What do you think? |
Actually not much. |
|
@OleksandrSPV Could you please add a description to the PR about what we actually do and any reason to use the |
Description added. There are many collisions between plugins packages at the current transition period (Eslint from version 8 to 9), so I decided to use the alpha version of this package to avoid them. I tested it a lot, including on another project, everything works well. |
|
@OleksandrSPV If we have already started using one spelling check method, then we should use it and not mix it with others. Let's use stylistic by default. |
* Add gh-pages * fix deploy comand --------- Co-authored-by: alex-slobodian <[email protected]>
I don't understand what kind of mixing you're talking about, sorry. Could you please clarify? @donskov |
I see that the |
Ok, let me think to optimise it. |
The typescript-eslint v.8 package was released, so there is no -alpha version of npm package now. I updated it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eslint deprecated formatting rules in version 9 https://eslint.org/blog/2023/10/deprecating-formatting-rules/. So lets use additional package for this https://eslint.style/guide/getting-started