Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line_break_between_method_arguments should count from beginning of line, including whitespaces #207

Open
ostrolucky opened this issue Nov 20, 2023 · 0 comments

Comments

@ostrolucky
Copy link
Contributor

ostrolucky commented Nov 20, 2023

I thought this fixer is great fit in combination with PSR-2's recommended 120 line length limit.

However, it looks like line_break_between_method_arguments is trimming the line from whitespaces and only then starts to calculate if content is longer than max-length.

This makes behavior quite non-compatible and non-predictable, because max-length is depending on indentation of current line. If I set it to 120 lines with intention to stick with PSR-2 limit, this will not work for intended code like so

     public function __construct(
         #[Assert\NotBlank(message: 'not_blank')]
         private string|UuidInterface $userFileImportId,
-        #[Assert\Choice(
-            callback: ['Eqsgroup\Entity\UserImport', 'getDuplicateResolutionStrategies'],
-            message: 'invalid_strategy',
-        )]
+        #[Assert\Choice(callback: ['Eqsgroup\Entity\UserImport', 'getDuplicateResolutionStrategies'], message: 'invalid_strategy', )]
         private string $strategy,
     ) {}

^ fixer changes above because even though code after fixing is longer than 120 lines, without whitespaces it's not

Attributes can be nested infinite times, which will push the limit towards PSR's 120 line length limit, but max-length option does not care about that

@ostrolucky ostrolucky changed the title line_break_between_method_arguments should from beginning of line, including whitespaces line_break_between_method_arguments should count from beginning of line, including whitespaces Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant