Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other real timbre #8

Open
timaschew opened this issue Dec 10, 2015 · 0 comments
Open

Other real timbre #8

timaschew opened this issue Dec 10, 2015 · 0 comments

Comments

@timaschew
Copy link
Contributor

I saw this comment https://github.com/PencilCode/musical.js/blob/master/musical.js#L1655-L1672 that the piano harmonics are used from a google project.

I tried to use the 32 harmonics of another instrument, like the guitar. Even if use all the 2000 harmonics, it always sound like a piano.

I found a library where a really nice guitar sound is created, you can here it here:
https://rawgit.com/timaschew/guitar-synth/master/example/index.html

I fixed an issue and removed some code, you can see the code here: https://github.com/timaschew/guitar-synth/tree/master/js
I think the main part is done here: https://github.com/timaschew/guitar-synth/blob/master/js/PluckedString.js

But the playing is done completely different than in musical.js and other webaudio libraries that I know.
It doesn't use any ac.createBuffer() or ac.createPeriodicWave
Instead it's done with this.node = this.context.createScriptProcessor(1024, 1, 1);

It would be nice if the guitar harmonics could be ported to musical.js somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant