Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure templated floating-point values are used throughout #366

Open
mlxd opened this issue Oct 4, 2022 · 0 comments
Open

Ensure templated floating-point values are used throughout #366

mlxd opened this issue Oct 4, 2022 · 0 comments
Assignees
Labels

Comments

@mlxd
Copy link
Member

mlxd commented Oct 4, 2022

Currently, Lightning has support throughout to enable strict use of templates for floating point values (float or double), and supports one type from Python through to CPP.

For the following function, we explicitly enable this as double, rather than the expected class template fp_t.

The goal is to ensure this is updated to use the fp_t value instead of explicitly using doubles or floats in the Measures class.

@mlxd mlxd changed the title Make this templated on fp_t and not explicitly double Make alg templated on fp_t and not explicitly double Oct 4, 2022
@mlxd mlxd changed the title Make alg templated on fp_t and not explicitly double Ensure templated floating-point values are used throughout Oct 5, 2022
@mlxd mlxd added good first issue Good for newcomers hacktoberfest labels Oct 5, 2022
@mlxd mlxd self-assigned this Oct 5, 2022
@mlxd mlxd closed this as completed Dec 19, 2022
@mlxd mlxd reopened this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant