Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build from pypi source tarball #397

Open
marcodelapierre opened this issue Jan 6, 2023 · 2 comments
Open

Unable to build from pypi source tarball #397

marcodelapierre opened this issue Jan 6, 2023 · 2 comments

Comments

@marcodelapierre
Copy link

Hi there,

while I was working on a Spack recipe for PennyLane and PennyLane-Lightning, I have noticed two small issues:

  1. the tarball from pypi does not contain CMakeLists.txt, hence the build fails; I resorted to using the github tarball for now
  2. CMake is not documented as source build dependency for PennyLane-Lightning; it might be useful for users to have it explicitly mentioned for this special type of builds.

For reference my Spack PR: spack/spack#34838

@AmintorDusko
Copy link
Contributor

Thank you for reporting this issue @marcodelapierre.
We will definitely look into this.

@mlxd
Copy link
Member

mlxd commented Jan 9, 2023

Hi @marcodelapierre thanks for reporting this. Just an FYI, there was some prior work started on adding Spack support back last year, but we never opened a PR due to additional commitments needed to complete this (https://github.com/mlxd/spack/tree/pennylane_lightning)

I'll try to take a look at your PR later this week, and see if we need to combine anything from my branch onto yours for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants