Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cope with recursive symlinks #16

Open
karenetheridge opened this issue May 8, 2015 · 2 comments
Open

cope with recursive symlinks #16

karenetheridge opened this issue May 8, 2015 · 2 comments
Assignees
@karenetheridge

Comments

@karenetheridge
Copy link
Member

re andk/pause#172

manifind runs File::Find, which might die on recursive symlinks; we should not die.
@shadowcat-mst
Copy link
Member

I just hit this - the fix is to add follow_skip => 2 to line 202 -

find({wanted => $wanted, follow_fast => 1, follow_skip => 2},

and then it'll just skip the second copy it finds; this wouldn't be nearly so much of a pain except that it applies the .SKIP patterns after this find() has completed, thereby meaning that SKIPping the symlinks doesn't save us.

@karenetheridge karenetheridge self-assigned this Dec 15, 2015
@eserte
Copy link

eserte commented May 22, 2022

Probably same issue as #5 and #6. The proposed solution with follow_skip=>2 looks good to me, is there any known or unknown problem with this solution?

eserte added a commit to eserte/bbbike that referenced this issue May 22, 2022
@eserte
monkeypatch ExtUtils::Manifest::manifind
168617b 
Use proposed solution from
Perl-Toolchain-Gang/ExtUtils-Manifest#16 to
work around "... is encountered a second time" problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenetheridge karenetheridge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eserte @shadowcat-mst @karenetheridge