Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koin 2.0 support #4

Open
victory1908 opened this issue May 11, 2019 · 4 comments
Open

koin 2.0 support #4

victory1908 opened this issue May 11, 2019 · 4 comments

Comments

@victory1908
Copy link

victory1908 commented May 11, 2019

Hi have u tried upgrade to koin 2.0. Seem like compile ok but does not work, always error no definition for viewmodel when install

@matghazaryan
Copy link

Hey Victory1908 did you manage to run it with Koin 2?

@hamedsilver
Copy link

@PhilippeBoisney I update to Koin 2 on my pull request you can check it :)
and I also update the libraries , and some small changes
#7

@matghazaryan
Copy link

@hamedsilver thank you for your efforts. One question how can I make User class parcelable? RIght now I can make it only Serializable.

@hamedsilver
Copy link

hamedsilver commented Mar 28, 2020

@matghazaryan why do you want to parcelable User class?
"Model" module is a kotlin module and not android module ,
if you want to pass user class by navigation to your destination you can map it to another class and you can put it in navigation module like this:
@Parcelize data class UserArgs( val id: String?, val login: String?, val name: String?, ... ) : Parcelable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants