-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unloading a pack does not work #81
Comments
I assume you mean the lobby SilentLobby-1? Please try to remove the "pack" option from the global section and see if that makes a difference. |
Also please make sure that your empty pack url/hash isn't.the same as the asm2 pack or any other pack, that would definitely cause issues. (It should also warn about that on startup) Also generally speaking "latest" is no a version, you'll want to provide the exact version string from the startup including the build number. |
The empty pack is not the same as the acm2 pack. I only replaced some values with placeholders to hide them. I also checked that the hash is correct and the file is accessible. The version is version: '1.8.7-SNAPSHOT (build 519)' (from bungee.yml). |
I just realized that I missed the first message of your reply. |
This logic has been slightly reworked to be compatible with the 1.20.3+ pack removal packet. Please retest if this still is an issue. |
I'm still having this issue with the following config and build 569. I'm running 1.20.4 and I see the removal attempt in the console, but it doesn't actually remove it. I have to use /usepack to swap back to the minigame pack, then to empty, and it will be removed. Config
|
Please remove |
It worked once randomly, but never again. The 1.20.4 client still doesn't unload the pack. Config
Log
|
According to your log the pack was removed so there is at least no error in the config/internal state logic. Are you saying that then the pack still was loaded in the client and no removal/pack load screen showed at that time? If so please check for errors in your client's latest.log. |
Yes, there's no indication on the client side whatsoever that it is trying to remove the pack, and it stays enabled. |
That's really weird seeing as they use the same code. Also the log message I mentioned before is sent directly after the removal request API was used so there can't be an error there and it was definitely called. Can you test without any other plugins? E.g. I see you have PacketEvents installed, maybe something is messing with the packets. |
I just tested it out with a brand new Velocity 3.3.0-SNAPSHOT (git-75d6dcc1-b371) install and no plugins besides VRP 1.9.0-SNAPSHOT (build 569), and it still didn't work. I see the ResourcePackSend, then the client sends 3 ResourcePackStatus packets, confirming it accepted, downloaded and loaded the pack, but there's never a remove packet. |
Used Version
BungeeResourcepacks latest (on August 2, 2023)
Config
Config
Environment description
Full Log
Log
What other programs/plugins are you running?
PartyAndFriends, Geyser-Bungeecord, Floodgate-Bungee, LiteBans, LuckPerms, PremiumVanish, RedisBungee, ReportSystem
(should all not affect resource packs)
What is happening?
Unloading packs via the empty pack is not working.
If a resource pack is loaded and I enter a server which has no resource pack, nothing happens.
If I use /resetpack false, it shows that the pack '' was stored and that I have no pack or the empty one loaded (but I have one loaded). But if I then try to load the currently used pack with /usepack , it shows the message that it is already loaded. But I cannot unload it with /resetpack altough the plugin knows that I have one loaded.
What did you expect to happen?
/resetpack or entering a server with no resource pack set will unload the resource pack (loading the empty one if one was previously loaded).
Additional context
The text was updated successfully, but these errors were encountered: