Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generated files into build directory #1564

Open
Gold856 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1572
Open

Move generated files into build directory #1564

Gold856 opened this issue Nov 12, 2024 · 0 comments · May be fixed by #1572
Labels
bug Something isn't working

Comments

@Gold856
Copy link
Contributor

Gold856 commented Nov 12, 2024

The clean task tends to not clean the version files that are generated directly into the source tree. The version file generation tasks should be changed to point to the build directory, with changes made to downstream consumers.
@Gold856 Gold856 added the bug Something isn't working label Nov 12, 2024
@Gold856 Gold856 mentioned this issue Nov 12, 2024
Merged
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 14, 2024
@Gold856
Clean up build
5b50a98 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
@Gold856 Gold856 linked a pull request Nov 14, 2024 that will close this issue
Open
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 15, 2024
@Gold856
Clean up build
669f539 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 15, 2024
@Gold856
Clean up build
77db2ff 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 15, 2024
@Gold856
Clean up build
eadbc8d 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 15, 2024
@Gold856
Clean up build
7645dc9 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
Gold856 added a commit to Gold856/photonvision that referenced this issue Nov 15, 2024
@Gold856
Clean up build
69e884c 
Fixes PhotonVision#1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up build Gold856/photonvision
1 participant
@Gold856