Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up build #1572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clean up build #1572

wants to merge 2 commits into from

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Nov 14, 2024

Fixes #1564. Also copies vendordep JSONs to the examples as advised by Thad. Removes unused shared/javacpp/setupBuild.gradle. Also removes unnecessary chmod +x gradlew from CI workflows.

@Gold856 Gold856 requested a review from a team as a code owner November 14, 2024 07:15
@mcm001
Copy link
Contributor

mcm001 commented Nov 14, 2024

Most specific pr title

@Gold856 Gold856 marked this pull request as draft November 15, 2024 02:19
@Gold856 Gold856 marked this pull request as ready for review November 15, 2024 02:32
@mcm001
Copy link
Contributor

mcm001 commented Nov 15, 2024

ready to review
fails lint

@Gold856 Gold856 force-pushed the clean-up-build branch 5 times, most recently from f9bfab5 to 8e0228c Compare November 15, 2024 06:17
@@ -1,3 +1 @@
apply from: "examples.gradle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just delete this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move generated files into build directory
3 participants