From 641bc0dd91b0e651ba843e556883f0460e08d39f Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 12 Nov 2024 01:11:15 -0500 Subject: [PATCH 1/6] Create pull_request_template.md --- .github/pull_request_template.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..215371929c --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,14 @@ +## Description + +What changed? Why? (the code + comments should speak for itself on the "how") + +Fun screenshots ir a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. + +## Meta + +Merge checklist: +- [ ] Pull Request title is [short, imperitive summary](https://cbea.ms/git-commit/) of proposed changes +- [ ] The description documents the _what_ and _why_, and leaverages screenshots +- [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly +- [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 +- [ ] If this PR addresses a bug, a regression test for it is added From c4182f9d34503349c16a248f7f34ac9bd8b019f5 Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 12 Nov 2024 01:13:09 -0500 Subject: [PATCH 2/6] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 215371929c..3f5118650f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ Fun screenshots ir a cool video or something are super helpful as well. If this Merge checklist: - [ ] Pull Request title is [short, imperitive summary](https://cbea.ms/git-commit/) of proposed changes -- [ ] The description documents the _what_ and _why_, and leaverages screenshots +- [ ] The description documents the _what_ and _why_, and leverages screenshots - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR addresses a bug, a regression test for it is added From 46cdc4f615a7cdf2cf2fcd9a4b4c5a2b84c75d9e Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 12 Nov 2024 01:13:35 -0500 Subject: [PATCH 3/6] Update pull_request_template.md --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3f5118650f..6f81debda5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,7 +8,7 @@ Fun screenshots ir a cool video or something are super helpful as well. If this Merge checklist: - [ ] Pull Request title is [short, imperitive summary](https://cbea.ms/git-commit/) of proposed changes -- [ ] The description documents the _what_ and _why_, and leverages screenshots +- [ ] The description documents the _what_ and _why_ - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 - [ ] If this PR addresses a bug, a regression test for it is added From edb3f1412f85775ae31a7a38c1b52746089c94a8 Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 12 Nov 2024 01:42:02 -0500 Subject: [PATCH 4/6] Update .github/pull_request_template.md Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6f81debda5..bfc886732b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,7 @@ Fun screenshots ir a cool video or something are super helpful as well. If this ## Meta Merge checklist: -- [ ] Pull Request title is [short, imperitive summary](https://cbea.ms/git-commit/) of proposed changes +- [ ] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [ ] The description documents the _what_ and _why_ - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1 From 08deda9e214e1274385b3909cd0313e547d49760 Mon Sep 17 00:00:00 2001 From: Matt Date: Tue, 12 Nov 2024 03:05:59 -0500 Subject: [PATCH 5/6] Update pull_request_template.md Co-authored-by: Jade --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index bfc886732b..26f353cc0f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,6 +4,8 @@ What changed? Why? (the code + comments should speak for itself on the "how") Fun screenshots ir a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. +Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`. + ## Meta Merge checklist: From 04f63bdd6ec1519d3c1f77dfc82e5878224759fb Mon Sep 17 00:00:00 2001 From: Jade Date: Fri, 15 Nov 2024 14:42:24 +0800 Subject: [PATCH 6/6] Update pull_request_template.md Co-authored-by: Joseph Eng <91924258+KangarooKoala@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 26f353cc0f..68480bcc36 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,7 +2,7 @@ What changed? Why? (the code + comments should speak for itself on the "how") -Fun screenshots ir a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. +Fun screenshots or a cool video or something are super helpful as well. If this touches platform-specific behavior, this is where test evidence should be collected. Any issues this pull request closes or pull requests this supersedes should be linked with `Closes #issuenumber`.