Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion because of PSR-7 #211

Open
g105b opened this issue May 3, 2023 · 1 comment
Open

Confusion because of PSR-7 #211

g105b opened this issue May 3, 2023 · 1 comment
Labels

Comments

@g105b
Copy link
Member

g105b commented May 3, 2023

Apparently it's a good idea to use PSR-7 when writing libraries that implement URLs, Requests, Responses, etc. but I'm coming to the opinion that it really doesn't matter at all, and PSRs actually just get in the way of what you're trying to do.

If this library's intention was to be interoperable with other Http libraries, maybe it would be a good idea to implement PSRs, but who has ever inter-operated anything in PHP? You refactor and get the job done.

This is not a rant about PSR. It's great to have consistency. But this library is suffering, because PSRs are not compatible with web standards.

@g105b g105b added the question label May 3, 2023
@g105b
Copy link
Member Author

g105b commented May 3, 2023

The main area of confusion is within classes surrounding Uri. The web standards call this class URL and it has a completely different set of methods and properties.

The knock on effect of dropping support will require a massive load of unpicking, but it would mean more web standards compliance, which is much more important to me and this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant