Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/configs/triggers): tmp disable sync for lt v8.x images #1264

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 23, 2024 08:13
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Sep 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change in this pull request is to temporarily disable sync for images that are lower than version 8.x in the image-push-on-harbor.yaml file. The change is made by modifying the regular expression pattern that matches the tag of the pushed image.

One potential problem with this pull request is that there is no explanation of why the sync needs to be disabled for images that are lower than version 8.x. Without this information, it is difficult to assess the impact of this change and whether it is necessary.

A possible suggestion to fix this is to add a brief explanation in the pull request description or in a comment in the code to clarify why the sync needs to be disabled for images that are lower than version 8.x. This will help reviewers to understand the context and assess the impact of the change.

Another possible suggestion is to consider making the regular expression pattern more flexible to allow for future changes in the versioning scheme. For example, instead of hardcoding the version number in the pattern, the pattern could be modified to match any tag that follows a specific format. This will make the code more adaptable to future changes in the versioning scheme.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 23, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 23, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1da5a48 into main Sep 23, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/temp-disable-low-version-image-trigger branch September 23, 2024 08:21
ti-chi-bot bot pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant