Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation does not match the latest version #4

Open
luzemario opened this issue Nov 13, 2020 · 14 comments
Open

Translation does not match the latest version #4

luzemario opened this issue Nov 13, 2020 · 14 comments
Assignees

Comments

@luzemario
Copy link

Hi folks. I translated Pinguino to pt_BR (Brazilian Portuguese), but the file have strings for Pinguino 11, so several strings does not match Pinguino 13 interface.

Can you give some clue to translate the correct file?

@luzemario
Copy link
Author

@MefhigosetH can you update the "files" folder with the latest version, please?

One more note: the line 63 of 'gents.py' can be updated to

os.system("pyside2-lupdate -verbose project.pro")

@MefhigosetH
Copy link
Member

Dear @luzemario ,

Sure. Thanks for your contribution.

@MefhigosetH MefhigosetH self-assigned this Nov 14, 2020
@MefhigosetH
Copy link
Member

Dear @luzemario ,

Sory for the delay. This month was very busy for me. It would be very helpful if you could fork the repo, make the changes you consider and submit a Pull Request back the the repo.

Thanks in advance, and best regards.

@luzemario
Copy link
Author

@MefhigosetH I found several errors when importing texts:

files/pinguino_core/pinguino.py:333: Unterminated string
�
files/pinguino_core/pinguino_tools.py:1359: Unterminated string
�
files/gide/app/code2blocks.py:232: Unterminated string
�
files/gide/app/graphical.py:807: Unterminated string
�
files/gide/app/work_area.py:1162: Unterminated string
�
files/ide/events.py:19: Unterminated string
�
files/ide/ide.py:252: Unterminated string
�
files/ide/tools/project.py:1368: Unterminated string
�
files/ide/tools/source_browser.py:196: Unterminated string
�
files/ide/tools/files.py:151: Unterminated string
�
files/ide/tools/stdout.py:19: Unterminated string
�
files/ide/tools/paths.py:111: Unterminated string
�
files/ide/child_windows/submit_bug.py:194: Unterminated string
�
files/ide/custom_widgets/plain_outputs/output_widget.py:404: Unterminated string
�
files/ide/custom_widgets/code_editor/pinguino_code_editor.py:54: Unterminated string
�
files/ide/custom_widgets/code_editor/autocompleter.py:204: Unterminated string
�
files/ide/custom_widgets/code_editor/editor.py:383: Unterminated string
�
files/ide/methods/core.py:2665: Unterminated string
�
files/ide/methods/timed_methods.py:240: Unterminated string
�

It appears to be some comments were made with quotation marks. I don't know Python, but quotation marks are valid for comments?

@luzemario
Copy link
Author

Here is a dirty (very dirty) hack:

https://www.reddit.com/r/Python/comments/2c0jy0/multiline_comment_switch/

@luzemario
Copy link
Author

So, adding a # before the last """ did the trick... :-)

@luzemario
Copy link
Author

Using quotation marks for comments is not recommended anymore. Unexpected (and hard to debug) erros can occur.

I could not get past files/gide/app/graphical.py:623: Unterminated string. It was not possible to figure out if it is a comment or a string to pass to an API.

@MefhigosetH
Copy link
Member

@MefhigosetH I found several errors when importing texts:

files/pinguino_core/pinguino.py:333: Unterminated string
�
files/pinguino_core/pinguino_tools.py:1359: Unterminated string
�
files/gide/app/code2blocks.py:232: Unterminated string
�
files/gide/app/graphical.py:807: Unterminated string
�
files/gide/app/work_area.py:1162: Unterminated string
�
files/ide/events.py:19: Unterminated string
�
files/ide/ide.py:252: Unterminated string
�
files/ide/tools/project.py:1368: Unterminated string
�
files/ide/tools/source_browser.py:196: Unterminated string
�
files/ide/tools/files.py:151: Unterminated string
�
files/ide/tools/stdout.py:19: Unterminated string
�
files/ide/tools/paths.py:111: Unterminated string
�
files/ide/child_windows/submit_bug.py:194: Unterminated string
�
files/ide/custom_widgets/plain_outputs/output_widget.py:404: Unterminated string
�
files/ide/custom_widgets/code_editor/pinguino_code_editor.py:54: Unterminated string
�
files/ide/custom_widgets/code_editor/autocompleter.py:204: Unterminated string
�
files/ide/custom_widgets/code_editor/editor.py:383: Unterminated string
�
files/ide/methods/core.py:2665: Unterminated string
�
files/ide/methods/timed_methods.py:240: Unterminated string
�

It appears to be some comments were made with quotation marks. I don't know Python, but quotation marks are valid for comments?

Dear @luzemario , thanks for your reply.

These are all the files that needs a change? I will try to modify then this week, so no more warnings apears.

@luzemario
Copy link
Author

I could fix most of them, but the last one above does not appear to be a comment (I do not program in Python, so I can't be sure).

@MefhigosetH
Copy link
Member

Ok. So I'll check this last item and give you feedback soon.

@MefhigosetH
Copy link
Member

@luzemario This line ?

@MefhigosetH
Copy link
Member

@luzemario
Copy link
Author

luzemario commented Nov 23, 2020

@luzemario Sory, I see the offensive line now:

https://github.com/PinguinoIDE/pinguino-ide/blob/5666a8e1a61f78f0f21bd89e741fcb9b1f8a9d38/pinguino/qtgui/gide/app/graphical.py#L617

I've found this issue https://bugreports.qt.io/browse/QTBUG-42736

Maybe your version of lupdate is old ?

Well, I am using pyside2-lupdate as suggested before. The version that come with Ubuntu 20.04 LTS is

Qt 5.12.8 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 9.3.0) on "xcb" 
OS: Ubuntu 20.04.1 LTS [linux version 5.4.0-54-generic]

They say this got fixed in Qt 5.12.2 on bug report.

@luzemario
Copy link
Author

The old version of Pinguno used pyside-lupdate before, so I don't know if pyside2-lupdate was patched too. There is no pyside-lupdate in Ubuntu 20.04 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants