Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update zoho_subscriptions to use Zoho Billing API endpoints #15008

Open
malexanderlim opened this issue Dec 17, 2024 · 4 comments · May be fixed by #15036
Open

[FEATURE] Update zoho_subscriptions to use Zoho Billing API endpoints #15008

malexanderlim opened this issue Dec 17, 2024 · 4 comments · May be fixed by #15036
Assignees
@michelle0927
Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@malexanderlim
Copy link
Collaborator

Zoho Subscriptions was rolled up into the Zoho Billing product as of June 2024. We should update all zoho_subscriptions endpoints to conform to the new Zoho Billing endpoints, as Zoho Subscriptions has been deprecated.

I've updated the app name and the test request for now, and all components should be updated as the majority of endpoints have changed.

https://www.zoho.com/billing/api/v1/introduction/?from_zsm=true
@malexanderlim malexanderlim added the enhancement New feature or request label Dec 17, 2024
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Dec 19, 2024
@michelle0927 michelle0927 self-assigned this Dec 19, 2024
@michelle0927 michelle0927 moved this from Prioritized to Doing in Component (Source and Action) Backlog Dec 19, 2024
@michelle0927 michelle0927 linked a pull request Dec 19, 2024 that will close this issue
Open
@michelle0927
Copy link
Collaborator

@malexanderlim The test request should be updated to use the new "billing" endpoint:
import { axios } from "@pipedream/platform"

export default defineComponent({
  props: {
    zoho_subscriptions: {
      type: "app",
      app: "zoho_subscriptions",
    }
  },
  async run({steps, $}) {
    return await axios($, {
      url: `${this.zoho_subscriptions.$auth.api_domain}/billing/v1/organizations`,
      headers: {
        "Authorization": `Zoho-oauthtoken ${this.zoho_subscriptions.$auth.oauth_access_token}`,
      },
    })
  },
})

@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Dec 19, 2024
@malexanderlim
Copy link
Collaborator Author

Thanks @michelle0927 - I've updated the test request and tested it, looks good to me!

@lcaresia lcaresia moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Dec 20, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to Changes Required in Component (Source and Action) Backlog Dec 23, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/FEATURE-Update-zoho_subscriptions-to-use-Zoho-Billing-API-endpoints-165bf548bb5e819aaf1ece54fbb5eb60

@michelle0927 michelle0927 moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Dec 23, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Dec 24, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Dec 24, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/FEATURE-Update-zoho_subscriptions-to-use-Zoho-Billing-API-endpoints-165bf548bb5e819aaf1ece54fbb5eb60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelle0927 michelle0927

Labels
enhancement New feature or request triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Status: Ready for Release
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update zoho_subscriptions to use Zoho Billing API endpoints PipedreamHQ/pipedream
3 participants
@michelle0927 @vunguyenhung @malexanderlim