Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart releaser creates releases for all the repos #7

Closed
Piwero opened this issue May 30, 2024 · 3 comments
Closed

Chart releaser creates releases for all the repos #7

Piwero opened this issue May 30, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Piwero
Copy link
Owner

Piwero commented May 30, 2024

Even when they aren't modified, it's creating new versions of all the repos. Breaking changes (semantic release) only affecting to test-1

@Piwero Piwero added the bug Something isn't working label May 30, 2024
@Piwero Piwero self-assigned this May 30, 2024
@Piwero Piwero changed the title Chart releaser creates releasers for all the repos Chart releaser creates releases for all the repos May 31, 2024
@Piwero
Copy link
Owner Author

Piwero commented May 31, 2024

@Piwero
Copy link
Owner Author

Piwero commented May 31, 2024

When making a change (and updating the chart version) for app-2, that triggers a release for test-1 app instead https://github.com/Piwero/helmseum/releases/tag/test-1-2.0.8

The above isn't true. It keeps creating all the releases even other apps haven't been updated. https://github.com/Piwero/helmseum/releases
They only thing is that they don't get sorted by last created.

@Piwero
Copy link
Owner Author

Piwero commented Jun 1, 2024

Steps to reproduce

  1. Edit a text in charts/app-2/templates/NOTES.txtand update version on Chart.yaml in the same commit (Until solution for Chart release doesn't auto bump version on release #9 is implemented) - This is only editing chart "app-2"
  2. Commit changes with a semantic release prefix: Commit message example"fix(app-2): Small change to trigger release for app-2"
  3. Push changes and wait for github actions to be success. https://github.com/Piwero/helmseum/actions
Screenshot 2024-06-01 at 09 36 01
  1. Visit releases , you will find that releases have been created for app-2 but also for test-1
Screenshot 2024-06-01 at 09 39 47

Expected behaviour

in step 4. , it only should create a release for app-2 due to no changes in test-1 app

@Piwero Piwero closed this as completed in 84b7425 Jun 1, 2024
@Piwero Piwero reopened this Jun 1, 2024
@Piwero Piwero closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant