Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are three traits for "weight of vines" trait: #64

Open
cooperl09 opened this issue Jun 4, 2018 · 2 comments · May be fixed by #76
Open

There are three traits for "weight of vines" trait: #64

cooperl09 opened this issue Jun 4, 2018 · 2 comments · May be fixed by #76
Assignees
Labels

Comments

@cooperl09
Copy link
Member

cooperl09 commented Jun 4, 2018

It's not clear from the names/definitions how these are different. Suggest modifying the names/definitions to make it clear, or get rid of any duplicates. Looks like two of these are actually fresh and dry weight.

[Term]
id: CO_331:0000224
name: sweetpotato weight of vines trait
def: "Weight of vines" [CO:curators]
synonym: "VnW" EXACT []

[Term]
id: CO_331:0000248
name: sweetpotato weight of vines trait
def: "Weight of vines samples" [CO:curators]
synonym: "VnFWt" EXACT []

[Term]
id: CO_331:0000252
name: sweetpotato weight of vines trait
def: "Weight of vines samples" [CO:curators]
synonym: "VnDWt" EXACT []

@bellerbrock
Copy link
Contributor

bellerbrock commented Oct 18, 2018

The vine weight measurements loaded into sweetpotatobase linked to ' Weight of vines measuring kg per plot|CO_331:0000227' appear to be measurements of the fresh weight of vines.

I'm thinking the simplest solution will be to keep just one trait and combine it with the two different methods (fresh vs dry) to have two different variables. I'll make that fix in a branch then submit it for review.

@bellerbrock
Copy link
Contributor

Actually, on closer inspection it looks like these should be kept as three separate variables, just with better clarification.

@bellerbrock bellerbrock linked a pull request Oct 18, 2018 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants