Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all public classes of CSP visible for user extension modules #365

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make all public classes of CSP visible for user extension modules #365

wants to merge 4 commits into from

Conversation

AdamGlustein
Copy link
Collaborator

Closes #363

@AdamGlustein AdamGlustein added the lang: c++ Issues and PRs related to the C++ codebase label Oct 2, 2024
@AdamGlustein AdamGlustein force-pushed the fix-symbol-visibility-for-user-extensions branch from 78e4af3 to 5cc011e Compare October 2, 2024 14:13
robambalu
robambalu requested changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@robambalu robambalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a build / test of a user extension node and adapter as part of this

cpp/csp/core/EnumBitSet.h Outdated Show resolved Hide resolved
cpp/csp/engine/CMakeLists.txt Outdated Show resolved Hide resolved
@AdamGlustein AdamGlustein force-pushed the fix-symbol-visibility-for-user-extensions branch from 5cc011e to 49a7bfa Compare October 2, 2024 15:53
@AdamGlustein AdamGlustein force-pushed the fix-symbol-visibility-for-user-extensions branch from 7fba64b to 5414d97 Compare October 7, 2024 19:31
@wrieg123 wrieg123 mentioned this pull request Oct 11, 2024
Closed
timkpaine
timkpaine reviewed Oct 16, 2024
View reviewed changes
cpp/cmake/modules/FindCSP.cmake
set(__csp_base_path "${CMAKE_SOURCE_DIR}/csp")
set(__csp_include_path "${CMAKE_SOURCE_DIR}/cpp")
set(__csp_lib_path "${CMAKE_SOURCE_DIR}/")
set(__csp_base_path "${CMAKE_SOURCE_DIR}/csp")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate with line 35 and the next line, i mustve had a stroke while writing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine left review comments

@robambalu robambalu robambalu requested changes

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

@ptomecek ptomecek Awaiting requested review from ptomecek ptomecek is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
lang: c++ Issues and PRs related to the C++ codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visibility too restrictive for externally defined C++ nodes & adapters
3 participants
@AdamGlustein @timkpaine @robambalu