Add non trophic interactions and stability measures

[ismael-lajaaiti]

Hello,

For an internship project I would to contribute to this package by implementing:

1. The possibility to add non trophic interactions (e.g. plant facilitation; for more details see Miele et al. 2019) to the species network
2. New measures (or metrics) of the community stability (see Dominguez et al. 2019)

Ismaël Lajaaiti

[ismael-lajaaiti]

I forked the repository here and I can not do an empty pull request, but I created one branch for 1. (non-trophic-interactions) and one for 2. (various-stability-metrics).

[evadelmas]

Hi @ilajaait - that sounds super interesting. Happy to help if you have any question about the implementation of the functions in the package.

[iago-lito]

Hello @evadelmas. I'm working with @ilajaait at the lab, and it is part of my mission to introduce/help him with all technical details related to julia/git/github/PRs/performance. As such, I am happy to collaborate :)

For instance, I can review the PRs offered in this context, but it seems that I need special accesses to this repo for that. What's the status of this repo? Would you agree that I become a reviewer, or a co-maintainer?

(We could also have a visio-chat first if you'd like, with Ismaël, myself, and his supervisor Sonia :)

[evadelmas]

Hello @iago-lito - always happy to welcome new collaborators on this package! :)
This repo is hosted by the Poisot lab, so I'm just waiting on @tpoisot's approval to add new collaborators but that shouldn't be a problem. After that you should be able to review the code.
There are other students from @andbeck's lab working on implementing new things into the BEFWM, and we are currently working on a new version (more compatible with the rest of EcoJulia and easier to maintain and modify) so I think it would be super useful for all of us to meet and discuss what we are all doing and how we can collaborate if that's something you would be interested in?

[iago-lito]

Definitely :) Let's set up a meeting by email then.

[tpoisot]

Hi @iago-lito and @ilajaait - and thanks for your interest in the package. I think @evadelmas will have added you as collaborators by then, so you can create branches rather work from a fork, which is usually easier to do collaborative changes.

[iago-lito]

Cool, thank you @tpoisot :)

BTW I have been puzzled by the wait-before-rebase policy described here. Does this restriction only concern branches from forked repos, or would it also hold for local branches here?

For instance, I would have cleaned up a couple of useless commits before merging #132, and avoided this blank merge commit in a rebase-then-fast-forward style. But maybe this is not how you like to work within this repo?

[tpoisot]

I think know the contribution guidelines are due for an update, they probably predate the first commit on the package.

Work as you usually would!