Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mob card #80

Closed
johartl opened this issue Sep 22, 2016 · 11 comments
Closed

Mob card #80

johartl opened this issue Sep 22, 2016 · 11 comments
Assignees

Comments

@johartl
Copy link
Collaborator

johartl commented Sep 22, 2016

Similar to the POI card where we display a Pokemon which was clicked on we need the same for a mob. Once the user clicks on a mob a bottom sheet should slide up which shows the following information.

  • The tweets which caused this mob (also see Implement Tweet-View #68)
  • Navigate to mob button
  • Optional: Show/Name the Pokemon that was named in each tweet
@AlexanderLill
Copy link
Collaborator

@johartl this can be closed after #87 is merged, right?

@WoH
Copy link
Member

WoH commented Oct 3, 2016

@AlexanderLill No, this is the Mob card, not the POI card.

@AlexanderLill
Copy link
Collaborator

@WoH but i saw some code in his PR that seemd to be handling the mobs :)

@johartl
Copy link
Collaborator Author

johartl commented Oct 3, 2016

That's a different concept because for the mobs we want to display the tweets causing that mob. But I'm sure we can reuse the swipe card and just fill it with different content.

@AlexanderLill
Copy link
Collaborator

Okay :) I was just trying to clean up the issues a little bit :)

@gyachdav
Copy link

gyachdav commented Oct 9, 2016

is this demoable?

@MajorBreakfast
Copy link
Contributor

MajorBreakfast commented Oct 16, 2016

@sacdallago Why did you assign me to this? I just saw that you assigned me a few days ago and I didn't know anything about it! If I had known I wouldn't have redesigned the PokeDex! What to do now? I can build the card. But proper mob integration is a lot more work. I thought @johartl was on it

@sacdallago
Copy link
Member

I assigned you and @Georrgi because one week ago @johartl was overloaded and I thought it'd be fair to redistribute a bit of the work :)

I thought this was only about the design, not the full integration. I seriously hope that is taken care of.

@MajorBreakfast
Copy link
Contributor

MajorBreakfast commented Oct 17, 2016

I'll take care of it.

BTW I haven't heard from @Georrgi for quite a while now. He hasn't contributed to the project so far. I unassign him for now.

I will work on this this evening.

@sacdallago
Copy link
Member

Good to know

@MajorBreakfast
Copy link
Contributor

#131 implements the PokeMob card

@WoH WoH closed this as completed Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants