Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of filter function #21

Open
johartl opened this issue Sep 21, 2016 · 7 comments
Open

Implementation of filter function #21

johartl opened this issue Sep 21, 2016 · 7 comments

Comments

@johartl
Copy link

johartl commented Sep 21, 2016

Your map needs to implement the filter function. Specification from PokemonGoers/Catch-em-all#24

  • filter({ pokemonIds, sightingsSince, predictionsUntil }) applies filter options to the map.
    • pokemonIds Array of Pokemon IDs which are shown (applies to predictions and sightings) on the map. If null show all 151 Pokemon.
    • sightingsSince Time in seconds for which sightings (includes mobs) in the past are shown. If 0 don't show any sightings.
    • predictionsUntil Time in seconds for which predictions are shown. If 0 don't show any predictions.

The filter function will make your updateTimeRange function obsolete.

@gqinami
Copy link
Collaborator

gqinami commented Sep 24, 2016

@johartl just for clarifications, would there be cases where we show predictions and sightings at the same time, or it is just one or the other??

Thanks

@johartl
Copy link
Author

johartl commented Sep 24, 2016

{
  sightingsSince: 3600,
  predictionsUntil: 1800,
  pokemonIds: null
}

In this case you would show sightings for the last hour and predictions for the next 30 minutes. So yes, there can be both :)

@johartl
Copy link
Author

johartl commented Oct 10, 2016

Are you guys still working on this?

@gqinami
Copy link
Collaborator

gqinami commented Oct 10, 2016

@johartl yes we are working on it. Will let you know soon when its done

@johartl
Copy link
Author

johartl commented Oct 17, 2016

Is this done guys?

@gqinami
Copy link
Collaborator

gqinami commented Oct 17, 2016

Yes it is done. Only predictions are not there yet, since we havent got the data for it.

@johartl
Copy link
Author

johartl commented Oct 17, 2016

Okay that's great! So I will keep this issue open until the predictions filtering is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants