Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward PokeMobs #43

Open
WoH opened this issue Oct 23, 2016 · 10 comments
Open

Forward PokeMobs #43

WoH opened this issue Oct 23, 2016 · 10 comments

Comments

@WoH
Copy link
Member

WoH commented Oct 23, 2016

screenshot from 2016-10-23 19-26-35

Could you foward the Mobs please? Our Side should be ready.

screenshot from 2016-10-23 19-26-59

Spec: PokemonGoers/Catch-em-all#23

@johartl
Copy link

johartl commented Oct 23, 2016

And then you can also disable the popover.

@sacdallago
Copy link
Member

@gyachdav

@oleks-fedotov
Copy link
Contributor

oleks-fedotov commented Oct 26, 2016

@WoH Will it be ok for you, if we fire the same event ('click'), as for pokemons? Or you have another one defined?

@WoH
Copy link
Member Author

WoH commented Oct 26, 2016

That's fine. We are treating them as 'POI' and check which type (Sighting, Prediction, Mob) you passed based on the props of the Obj you pass.

@oleks-fedotov
Copy link
Contributor

@WoH So for Prediction and Sighting you also need the whole object? because currently only pokemonId is passed

@WoH
Copy link
Member Author

WoH commented Oct 26, 2016

@WoH
Copy link
Member Author

WoH commented Oct 26, 2016

We will need the whole Object, if you emit 'click' this is the function we pass it into.

@oleks-fedotov
Copy link
Contributor

thanks for a reference. Then we will pass the whole object, that's not a problem.

@oleks-fedotov
Copy link
Contributor

Please check the new version of the package(0.1.9). Pokemobs are now forwarded, popups removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants