Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdap.io Open Graph defaults #173

Open
1 task
josh-chamberlain opened this issue Oct 31, 2023 · 2 comments
Open
1 task

pdap.io Open Graph defaults #173

josh-chamberlain opened this issue Oct 31, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Oct 31, 2023

companion to Police-Data-Accessibility-Project/data-sources-app#199

Context

When we share links, they look like this:
Screen Shot 2023-10-31 at 3 15 58 PM

But if we use open graph, they can be more custom and modern looking.

Requirements

Properties

These are sensible defaults, but should allow overrides downstream

  • og:site_name: PDAP
  • og:image: src/images/acronym.svg
  • og:title: all pages have titles, right? can default to Police Data Accessibility Project though.
  • og:type: website
  • og:description: we sometimes define this in other meta tags, but could use Data and tools for answering questions about any police system in the United States.
  • og:url: ?
@josh-chamberlain josh-chamberlain added the good first issue Good for newcomers label Oct 31, 2023
@joshuagraber
Copy link
Contributor

Hey, @josh-chamberlain I was looking through open issues this morning and started to look into this.

My thinking is that we want to make these updates in pdap.io and data-sources/client directly. I'm not sure how we handle this gracefully in design-system, because whatever we would devise to handle it would need to know about the existing routes in all of the other apps.

My proposal is to clone this issue into both of the apps where the update is needed and use an existing npm package like vue-meta to handle this for each route. Does that sound like a good strategy to you?

@josh-chamberlain josh-chamberlain transferred this issue from Police-Data-Accessibility-Project/design-system Jan 30, 2024
@josh-chamberlain josh-chamberlain changed the title Open Graph defaults pdap.io Open Graph defaults Jan 30, 2024
@josh-chamberlain
Copy link
Contributor Author

@joshuagraber makes sense to me, I have cloned the issue. I think starting with sensible defaults is good enough for now, we just need a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: To do
Status: Todo
Development

No branches or pull requests

2 participants