Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vanilla key refactor #121

Open
astrsh opened this issue Jul 1, 2022 · 1 comment
Open

Vanilla key refactor #121

astrsh opened this issue Jul 1, 2022 · 1 comment
Labels
biome A new biome addition enhancement New feature or request patch This issue will constitute a patch version bump priority=medium Medium priority issues requires additional functionality This issue requires additional functionality implemented by Terra

Comments

@astrsh
Copy link
Member

astrsh commented Jul 1, 2022

Quotes from @duplexsystem

once biome config gets merged we should go back though the vanilla key for each biome and choose one that actually suits the biome (for spawning and structures, etc) and modify any values that need to be changed on the terra side

Referenced PR - PolyhedralDev/Terra#330

also in line with that I think volcanoes should be not badlands because it's weird with strucure mods and mobs that are in badlands

also we should go over each biome to add new particles, ambiance, etc
@astrsh astrsh added enhancement New feature or request biome A new biome addition priority=medium Medium priority issues requires additional functionality This issue requires additional functionality implemented by Terra patch This issue will constitute a patch version bump labels Jul 1, 2022
@astrsh
Copy link
Member Author

astrsh commented Aug 7, 2022

defb147 replaces vanilla keys with an environment which primarily determines biome colors, other behaviour such as mob spawns will still need to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
biome A new biome addition enhancement New feature or request patch This issue will constitute a patch version bump priority=medium Medium priority issues requires additional functionality This issue requires additional functionality implemented by Terra
Projects
Terra 7.0.0 & Overworld 2.0
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@astrsh