Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_encodeBodyObject outputs "null" when body is null and contentType is application/json #284

Open
elvinfucom opened this issue Jul 17, 2017 · 4 comments
Open

_encodeBodyObject outputs "null" when body is null and contentType is application/json #284

elvinfucom opened this issue Jul 17, 2017 · 4 comments

Comments

@elvinfucom
Copy link

Description

_encodeBodyObject in iron-request element outputs "null" when body is null and contentType is application/json.

Can the _encodeBodyObject do a null check on body to avoid the meaningless calling of JSON.stringify?
@drix
Copy link

drix commented Jul 20, 2017 •
edited
Loading

i'm on it!

  • It is not just to avoid a useless JSON.stringify with the check, but, it actually generate an error on node.js express when using method DELETE

@elvinfucom
Copy link
Author

Good to hear that! Thanks.

drix pushed a commit to drix/iron-ajax that referenced this issue Jul 21, 2017
Fixes PolymerElements#284 by checking if body is null
31b4263
@drix drix mentioned this issue Jul 21, 2017
Closed
@drix
Copy link

drix commented Jul 21, 2017

The pull request is done, let's see how long it takes to be merged, it is blocking by DEV enviroment

@drix
Copy link

drix commented Jul 26, 2017

11 pull requests ... it seems nobody is checking it, they should let the community accept pulls with some rules, of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elvinfucom @drix