Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IronButtonState: code review #28

Open
1 of 2 tasks
notwaldorf opened this issue Aug 10, 2015 · 0 comments
Open
1 of 2 tasks

IronButtonState: code review #28

notwaldorf opened this issue Aug 10, 2015 · 0 comments
Labels
good-first-bug p1 - backlog
Milestone
2.0

Comments

@notwaldorf
Copy link
Contributor

  • pointerDown, receiveFocus... and _mouseEventRe should be proper private, and not defined in the properties block
  • should import iron-control-state.html
@notwaldorf notwaldorf changed the title IronControlState: code review issues IronButtonState: code review issues Aug 10, 2015
@notwaldorf notwaldorf changed the title IronButtonState: code review issues IronButtonState: code review Aug 10, 2015
@notwaldorf notwaldorf mentioned this issue Aug 10, 2015
Open
5 tasks
@notwaldorf notwaldorf added this to the 2.0 milestone Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-bug p1 - backlog
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@cdata @notwaldorf