Skip to content
This repository has been archived by the owner on Dec 28, 2024. It is now read-only.

Request: Add mixin for #sizedImgDiv #79

Open
8 tasks done
kristfal opened this issue Jun 8, 2016 · 3 comments
Open
8 tasks done

Request: Add mixin for #sizedImgDiv #79

kristfal opened this issue Jun 8, 2016 · 3 comments

Comments

@kristfal
Copy link

kristfal commented Jun 8, 2016

Description

A use case for iron-image can be to add a box shadow inset in order to render a gradient across the image, such as:

-webkit-box-shadow: inset 0px -29px 55px -18px rgba(0,0,0,0.65);
box-shadow: inset 0px -29px 55px -18px rgba(0,0,0,0.65);

Setting this style on iron-image will not render as #sizedImgDiv is rendered on top of the iron-image tags.

Expected outcome

Should be able to use box-shadow insets with iron-image

Actual outcome

Box shadow insets is not rendering because they need to be applied to #sizedImgDiv

Proposed solution

Add a mixin to #sizedImgDiv

Let me know if you want a PR.

Browsers Affected

  • Chrome
  • Firefox
  • Safari 9
  • Safari 8
  • Safari 7
  • Edge
  • IE 11
  • IE 10
@bicknellr
Copy link
Contributor

If you'd like to submit a PR, feel free; this doesn't seem contentious or breaking.

@kristfal
Copy link
Author

@bicknellr See #83. Also, tests are failing for Firefox – there seems to be an issue with the CI.

@bicknellr
Copy link
Contributor

Yeah, we've been having some issues with Firefox and the test framework lately. Thanks for the PR. After considering this again, I think this might be outside the scope of iron-image given that img also behaves this way. Here's a demo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants