-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animationConfig does not work on neon-animation-pages #209
Comments
Quick question here : |
Hi @vguillou, yes i did. It was working when i use 'entry-animation' and 'exit-animation' instead of 'animation-config'. |
I'm having the same problem, from what I see in the source the animationConfig object gets cleared out when switching to another page. See https://github.com/PolymerElements/neon-animation/blob/master/neon-animated-pages.html on line 107. |
Same problem here |
@araker is exactly right. I think this is WAI, in the sense that |
Expanding or collapsing a section takes 350ms, but fading the new content in and the old content out takes 500ms. This is a contributing factor to the overlap seen when closing a section, as the old section is still visible when the collapse animation has completed. Shortening the fade duration to match the expand/collapse animation makes that overlap much less likely to occur. It also makes the animations appear snappier, IMO -- if the page is still fading after expanding, it looks slugging. This re-implements the fade animations, rather than programmatically changing the neon-animated-pages' transition durations for the existing fade-in-animation/fade-out-animation. The latter is not possible due to PolymerElements/neon-animation#209. [email protected] BUG=716680 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856223007 Cr-Commit-Position: refs/heads/master@{#469582}
Expanding or collapsing a section takes 350ms, but fading the new content in and the old content out takes 500ms. This is a contributing factor to the overlap seen when closing a section, as the old section is still visible when the collapse animation has completed. Shortening the fade duration to match the expand/collapse animation makes that overlap much less likely to occur. It also makes the animations appear snappier, IMO -- if the page is still fading after expanding, it looks slugging. This re-implements the fade animations, rather than programmatically changing the neon-animated-pages' transition durations for the existing fade-in-animation/fade-out-animation. The latter is not possible due to PolymerElements/neon-animation#209. [email protected] BUG=716680 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2856223007 Cr-Original-Commit-Position: refs/heads/master@{#469582} Review-Url: https://codereview.chromium.org/2889653005 . Cr-Commit-Position: refs/branch-heads/3071@{#590} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
@mgiuffrida like this? I tried it but the effect doesn't seem to take effect In Polymer 1.... <neon-animated-pages
animation-config="[[animationConfig]]"
selected="{{parent}}"
id="foo">
<module-settings slot="other" id="bob" name="module-settings" provider="[[provider]]"></module-settings>
--------------------------------
animationConfig: {
value: function() {
return {
'entry': [
{name: 'slide-from-right-animation' },
{animatable: this.$.bob, type: 'entry'}
]
}
}
}, |
Hi, I am trying to change the duration of animation for neon-animation-pages as follow.
However, it doesnt work. Not only the duration is not applied and also the animation 'slid-from-right-animation' and 'slide-left-animation'.
Any idea what am i missing?
Thanks for advise.
The text was updated successfully, but these errors were encountered: