Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

allow disabling PaperInkyFocusBehavior? #113

Closed
jab opened this issue May 5, 2017 · 3 comments
Closed

allow disabling PaperInkyFocusBehavior? #113

jab opened this issue May 5, 2017 · 3 comments

Comments

@jab
Copy link

jab commented May 5, 2017

We're seeing unwanted keyboard focus-related styles on our paper-icon-buttons, in particular on mobile, where we're specifically only building for the no-keyboard use case. I’ve tracked this down to PaperInkyFocusBehavior, which is unconditionally added to paper-icon-button's behaviors. Would it be possible to allow paper-icon-button users to opt out of PaperInkyFocusBehavior?

(In the meantime, we can work around this by pegging to a fork of paper-behaviors with a modified _focusChanged method. As a bonus, it also works around this issue, which we're also hitting: PolymerElements/paper-menu-button#101)

Thanks for your consideration and for all the great work!

@jab
Copy link
Author

jab commented May 5, 2017

(To be clear, we still want the ripple when the button is tapped, we just don’t want the button to get any different styles when it has focus.)

@notwaldorf
Copy link
Contributor

This is bad for a11y, and it's not a thing we'd like to give the option to accidentally turn off :(

@jab
Copy link
Author

jab commented Jun 13, 2017

Thanks for taking a look @notwaldorf! After digging a little deeper, I think this is actually a bug in paper-behaviors. Just opened PolymerElements/paper-behaviors#80, and will close this now since it seems like discussion should move there.

@jab jab closed this as completed Jun 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants