Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

[1.0] There is no ripple effect when button is pressed by "Enter" key #21

Open
dzhioev opened this issue Jun 6, 2015 · 6 comments
Open

Comments

@dzhioev
Copy link

dzhioev commented Jun 6, 2015

In contrast to <paper-button>, <paper-icon-button> doesn't have the ripple effect when pressed by "Enter" key.

@arthurvr
Copy link

arthurvr commented Jun 7, 2015

Hmmm... for me there actually seems to be a ripple.

Can you post a reduced testcase? What browser was you using? There are some browser extensions known to be screwing up handlers, so can you try in an incognito window?

@dzhioev
Copy link
Author

dzhioev commented Jun 10, 2015

@arthurvr Are you sure, that you used the Enter keyboard key when pressed a button?
Steps to reproduce:

  1. Go to https://elements.polymer-project.org/bower_components/paper-icon-button/demo/index.html
  2. Focus any button using Tab key.
  3. Press Enter or Space key.
    My browser is Google Chrome 43.0.2357.81 (Official Build) (64-bit).

@arthurvr
Copy link

  1. Focus any button using Tab key.

Indeed. Then I'm able to reproduce this. Try to be a little more complete next time when making a bug report :) If you click once and then do it again by pressing enter there actually is a ripple, strange.

@dzhioev
Copy link
Author

dzhioev commented Sep 26, 2015

@notwaldorf Could you please look into this?

@tjsavage
Copy link
Contributor

This is also a material design bug - there is no differentiation in the "icon-toggles" section of the spec between focused and pressed state.

For non-toggle paper-icon-buttons, I think the solution here should be to replay the ripple animation when keyboard focused and then activated with or , but keep the inky ring visible so that it remains focused.

@robrez
Copy link

robrez commented Aug 8, 2016

Just to provide some additional info:

paper-icon-button-light has an inverted problem - it does replay the ripple animation when activated, but removes the inky-focus after the animation has finished.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants