Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Feature request: requesting changes on a PR should change the item to "no action required" #240

Closed
notwaldorf opened this issue Mar 7, 2018 · 4 comments
Assignees
Milestone

Comments

@notwaldorf
Copy link

notwaldorf commented Mar 7, 2018

Not sure if you can detect this, but if I've requested changes on a PR, i'd expect it to see that item a blue "no action required", until the human at the end of the line makes the changes.

@e111077
Copy link

e111077 commented Mar 7, 2018

perhaps we can have a github bot add and remove a pending response label?

@samuelli
Copy link
Member

samuelli commented Mar 7, 2018

@notwaldorf: link to a sample PR? We should be able to do this.

@rictic
Copy link

rictic commented Mar 7, 2018

Polymer/polymer-linter#152 is a PR whose current state is "requested changes."

I'd like it to switch back to an orange "needs your review" sorta state if the PR author adds commits or comments to the PR.

@bicknellr
Copy link

another example: PolymerElements/iron-selector#149

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants