Status not updated after PR was rebased

[dstoc]

The Problem

I reviewed a patch with comments and it was updated to address them, but the UI still says "You reviewed with comments". I assume the change were pushed as a rebase (git push -f)

Expected Behavior

Expected to see "1 new commit"

Links to Relevant PR's / Issues

PolymerLabs/arcs#1263

[samuelli]

After some debugging, it looks like pushedDate is null. Not really sure I understand why since that seems to be the one we care about. I think maybe the commit was amended and hence why the authoredDate is quite far in the past. The only value that appears to work in this particular case seems to be commitedDate - I'm not quite convinced we always want to be using this instead though.

[samuelli]

commitedDate and authoredDate can't be null per https://developer.github.com/v4/object/commit/ but if pushedDate is present, that's the one we want to use.