Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

New read activity spot does not go away when "right-click -> open in new tab" a link #557

Open
TimvdLippe opened this issue Aug 10, 2018 · 2 comments
Labels
feature request new features

Comments

@TimvdLippe
Copy link

The Problem

I tend to "ctrl + click" a lot of my URLs, to not accidentally move from my current tab. Luckily, Project health has target=_blank so this shouldn't happen. Still, I am used to "ctrl + click" my way through the internet.

However, when I "right click -> open link in new tab" (rather than just click or "ctrl + click"), the "new read activity" spot that is next to an outgoing PR is not removed. The outcome of the two methods is the same nonetheless, e.g. a new tab opens with the corresponding URL.

A spot next to a link:
image

Expected Behavior

When I "right click -> open link in new tab" on a link with new read activity, it should become read.

Links to Relevant PR's / Issues

n/a

@samuelli samuelli added the feature request new features label Aug 14, 2018
@samuelli
Copy link
Member

samuelli commented Aug 20, 2018

That's a good point @TimvdLippe. However, I'm not sure if there's really any way to detect this case.

One (rather complex) solution would be to change all the URLs to internal URLs so that we can track which ones you went to, regardless of how you opened them. That may be more complex than needed?

@TimvdLippe
Copy link
Author

Hm, yes that seems too complex. While we can not capture the "new tab" after a right click, I think listening for oncontextmenu might be just sufficient (https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/oncontextmenu) ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request new features
Projects
None yet
Development

No branches or pull requests

2 participants