From ce355d4bb0988c85f64c80cc1f2e6e612109dcc1 Mon Sep 17 00:00:00 2001
From: Paul D'Ambra <paul@posthog.com>
Date: Tue, 3 Sep 2024 15:55:02 +0100
Subject: [PATCH] fix: captured network requests must always have name property

---
 src/entrypoints/recorder.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/entrypoints/recorder.ts b/src/entrypoints/recorder.ts
index c49c995c1..793d5003c 100644
--- a/src/entrypoints/recorder.ts
+++ b/src/entrypoints/recorder.ts
@@ -321,6 +321,7 @@ function initXhrObserver(cb: networkCallback, win: IWindow, options: Required<Ne
                                 networkRequest,
                                 start,
                                 end,
+                                url: url.toString(),
                             })
                             cb({ requests })
                         })
@@ -353,6 +354,7 @@ function prepareRequest({
     isInitial,
     start,
     end,
+    url,
 }: {
     entry: PerformanceResourceTiming | null
     method: string | undefined
@@ -361,6 +363,8 @@ function prepareRequest({
     isInitial?: boolean
     start?: number
     end?: number
+    // if there is no entry, we still need to know the url
+    url?: string
 }): CapturedNetworkRequest[] {
     start = entry ? entry.startTime : start
     end = entry ? entry.responseEnd : end
@@ -375,7 +379,7 @@ function prepareRequest({
     // use timeOrigin if we really can't gather a start time
     const timestamp = Math.floor(timeOrigin + (start || 0))
 
-    const entryJSON = entry ? entry.toJSON() : {}
+    const entryJSON = entry ? entry.toJSON() : { name: url }
 
     const requests: CapturedNetworkRequest[] = [
         {
@@ -578,6 +582,7 @@ function initFetchObserver(
                             networkRequest,
                             start,
                             end,
+                            url: req.url,
                         })
                         cb({ requests })
                     })