From 32d72fd112eb1371899e5d55d3d0ecd724ba5789 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bruno=20Guimar=C3=A3es?= Date: Mon, 9 Sep 2024 13:12:59 -0300 Subject: [PATCH 1/2] adds the fallback for retrocompatible LCP apps --- src/extensions/web-vitals/index.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/extensions/web-vitals/index.ts b/src/extensions/web-vitals/index.ts index 622fde5e0..d91a5fc9a 100644 --- a/src/extensions/web-vitals/index.ts +++ b/src/extensions/web-vitals/index.ts @@ -195,17 +195,20 @@ export class WebVitalsAutocapture { let onCLS: WebVitalsMetricCallback | undefined let onFCP: WebVitalsMetricCallback | undefined let onINP: WebVitalsMetricCallback | undefined - + const posthogExtensions = assignableWindow.__PosthogExtensions__ if (!isUndefined(posthogExtensions)) { ;({ onLCP, onCLS, onFCP, onINP } = posthogExtensions.postHogWebVitalsCallbacks) } - + else if (assignableWindow.postHogWebVitalsCallbacks) { + ({ onLCP, onCLS, onFCP, onINP } = assignableWindow.postHogWebVitalsCallbacks); + } + if (!onLCP || !onCLS || !onFCP || !onINP) { logger.error(LOGGER_PREFIX + 'web vitals callbacks not loaded - not starting') return } - + // register performance observers if (this.allowedMetrics.indexOf('LCP') > -1) { onLCP(this._addToBuffer.bind(this)) @@ -219,7 +222,7 @@ export class WebVitalsAutocapture { if (this.allowedMetrics.indexOf('INP') > -1) { onINP(this._addToBuffer.bind(this)) } - + this._initialized = true } } From 4845dbbb607698e7e8af6baa045e7169ff975ebd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bruno=20Guimar=C3=A3es?= <39094505+brunomguimaraes@users.noreply.github.com> Date: Mon, 9 Sep 2024 13:18:16 -0300 Subject: [PATCH 2/2] empty spaces --- src/extensions/web-vitals/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/extensions/web-vitals/index.ts b/src/extensions/web-vitals/index.ts index d91a5fc9a..59403bec2 100644 --- a/src/extensions/web-vitals/index.ts +++ b/src/extensions/web-vitals/index.ts @@ -195,7 +195,7 @@ export class WebVitalsAutocapture { let onCLS: WebVitalsMetricCallback | undefined let onFCP: WebVitalsMetricCallback | undefined let onINP: WebVitalsMetricCallback | undefined - + const posthogExtensions = assignableWindow.__PosthogExtensions__ if (!isUndefined(posthogExtensions)) { ;({ onLCP, onCLS, onFCP, onINP } = posthogExtensions.postHogWebVitalsCallbacks) @@ -208,7 +208,7 @@ export class WebVitalsAutocapture { logger.error(LOGGER_PREFIX + 'web vitals callbacks not loaded - not starting') return } - + // register performance observers if (this.allowedMetrics.indexOf('LCP') > -1) { onLCP(this._addToBuffer.bind(this)) @@ -222,7 +222,7 @@ export class WebVitalsAutocapture { if (this.allowedMetrics.indexOf('INP') > -1) { onINP(this._addToBuffer.bind(this)) } - + this._initialized = true } }