From 07175a697c92df00089d4e28d5428d7a56c2bbb9 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Tue, 24 Oct 2023 18:18:22 +0100 Subject: [PATCH 1/3] check eslint in CI --- src/extensions/replay/sessionrecording.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/extensions/replay/sessionrecording.ts b/src/extensions/replay/sessionrecording.ts index f5046ddd8..edca03ccb 100644 --- a/src/extensions/replay/sessionrecording.ts +++ b/src/extensions/replay/sessionrecording.ts @@ -598,6 +598,10 @@ export class SessionRecording { const isBelowMinimumDuration = _isNumber(minimumDuration) && _isNumber(sessionDuration) && sessionDuration < minimumDuration + if (minimumDuration === null || sessionDuration === null) { + logger.warn(`ESLint should fail in CI`) + } + if (this.status === 'buffering' || isBelowMinimumDuration) { this.flushBufferTimer = setTimeout(() => { this._flushBuffer() From 23ed41abfedacfe01e8e78cbead32e1306747ed5 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Tue, 24 Oct 2023 18:43:25 +0100 Subject: [PATCH 2/3] run the correct command --- .github/workflows/library-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/library-ci.yml b/.github/workflows/library-ci.yml index 8de989a55..a8e01ba8a 100644 --- a/.github/workflows/library-ci.yml +++ b/.github/workflows/library-ci.yml @@ -77,5 +77,5 @@ jobs: - run: | yarn prettier --check - yarn eslint + yarn lint yarn tsc -b From 32dd28f5c2e8349c7601ea63358d7a0ab2d64d58 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Tue, 24 Oct 2023 18:47:17 +0100 Subject: [PATCH 3/3] remove the code that forced linter to fail --- src/extensions/replay/sessionrecording.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/extensions/replay/sessionrecording.ts b/src/extensions/replay/sessionrecording.ts index edca03ccb..f5046ddd8 100644 --- a/src/extensions/replay/sessionrecording.ts +++ b/src/extensions/replay/sessionrecording.ts @@ -598,10 +598,6 @@ export class SessionRecording { const isBelowMinimumDuration = _isNumber(minimumDuration) && _isNumber(sessionDuration) && sessionDuration < minimumDuration - if (minimumDuration === null || sessionDuration === null) { - logger.warn(`ESLint should fail in CI`) - } - if (this.status === 'buffering' || isBelowMinimumDuration) { this.flushBufferTimer = setTimeout(() => { this._flushBuffer()