From 1ea79bcf0c2b0af740cc1e9e12fd9fadcf07c6b5 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Sun, 29 Oct 2023 08:37:22 +0000 Subject: [PATCH 1/5] feat: don't report on file size of files we can infer from the main files --- .github/workflows/bundled-size.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/bundled-size.yaml b/.github/workflows/bundled-size.yaml index 7ce3d011d..0f12905d8 100644 --- a/.github/workflows/bundled-size.yaml +++ b/.github/workflows/bundled-size.yaml @@ -12,3 +12,4 @@ jobs: with: build-script: "build-rollup" compression: "none" + exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js}" From 1e63ec4b2f7a472f8820b8e603b8b996963c6582 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Sun, 29 Oct 2023 08:40:25 +0000 Subject: [PATCH 2/5] add minimum size threshold for reporting --- .github/workflows/bundled-size.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/bundled-size.yaml b/.github/workflows/bundled-size.yaml index 0f12905d8..195b2a756 100644 --- a/.github/workflows/bundled-size.yaml +++ b/.github/workflows/bundled-size.yaml @@ -12,4 +12,7 @@ jobs: with: build-script: "build-rollup" compression: "none" + # no need to report on files that aren't the interesting ones exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js}" + # no need to report on very small byte changes which show as 0% changed + minimum-change-threshold: 300 From 27a06ea1bd6194bdac4b9bd2158f5fe541774677 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Sun, 29 Oct 2023 08:43:04 +0000 Subject: [PATCH 3/5] Update bundled-size.yaml --- .github/workflows/bundled-size.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bundled-size.yaml b/.github/workflows/bundled-size.yaml index 195b2a756..bc9aed04a 100644 --- a/.github/workflows/bundled-size.yaml +++ b/.github/workflows/bundled-size.yaml @@ -13,6 +13,6 @@ jobs: build-script: "build-rollup" compression: "none" # no need to report on files that aren't the interesting ones - exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js}" + exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,./node_modules/*}" # no need to report on very small byte changes which show as 0% changed minimum-change-threshold: 300 From a28b214163921b54b0a7a5aec85964b16aa134f8 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Sun, 29 Oct 2023 08:43:44 +0000 Subject: [PATCH 4/5] Update bundled-size.yaml --- .github/workflows/bundled-size.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bundled-size.yaml b/.github/workflows/bundled-size.yaml index bc9aed04a..18f5d9711 100644 --- a/.github/workflows/bundled-size.yaml +++ b/.github/workflows/bundled-size.yaml @@ -13,6 +13,6 @@ jobs: build-script: "build-rollup" compression: "none" # no need to report on files that aren't the interesting ones - exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,./node_modules/*}" - # no need to report on very small byte changes which show as 0% changed + exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,**/*.map,**/node_modules/**}" + # no need to report on very small byte changes which show as 0% change minimum-change-threshold: 300 From b8a1a4ff56eca7979a32de1f6219a29be0783e19 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Sun, 29 Oct 2023 08:47:42 +0000 Subject: [PATCH 5/5] Update bundled-size.yaml --- .github/workflows/bundled-size.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bundled-size.yaml b/.github/workflows/bundled-size.yaml index 18f5d9711..0b2a69651 100644 --- a/.github/workflows/bundled-size.yaml +++ b/.github/workflows/bundled-size.yaml @@ -13,6 +13,6 @@ jobs: build-script: "build-rollup" compression: "none" # no need to report on files that aren't the interesting ones - exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,**/*.map,**/node_modules/**}" + exclude: "{dist/es.js,dist/module.js,**/*.map,**/node_modules/**}" # no need to report on very small byte changes which show as 0% change minimum-change-threshold: 300