From 2e60b33d4c395509676740d8d0f04b345ee6e399 Mon Sep 17 00:00:00 2001 From: Julian Bez Date: Wed, 12 Jun 2024 11:14:54 +0100 Subject: [PATCH] fix(insights): Fix dashboard not stale when removing date (#22888) Fix dashboard not stale when removing date --- .../src/scenes/dashboard/dashboardLogic.tsx | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/frontend/src/scenes/dashboard/dashboardLogic.tsx b/frontend/src/scenes/dashboard/dashboardLogic.tsx index 24cbda0dce21f..1d18ab9c31ac9 100644 --- a/frontend/src/scenes/dashboard/dashboardLogic.tsx +++ b/frontend/src/scenes/dashboard/dashboardLogic.tsx @@ -826,12 +826,17 @@ export const dashboardLogic = kea([ stale: [ (s) => [s.temporaryFilters, s.dashboard], (temporaryFilters, dashboard) => { - return !!( - (temporaryFilters.date_from && temporaryFilters.date_from !== dashboard?.filters.date_from) || - (temporaryFilters.date_to && temporaryFilters.date_to !== dashboard?.filters.date_to) || - (temporaryFilters.properties && - JSON.stringify(temporaryFilters.properties) !== JSON.stringify(dashboard?.filters.properties)) - ) + const isDateFromStale = + !!(temporaryFilters.date_from || dashboard?.filters.date_from) && + temporaryFilters.date_from !== dashboard?.filters.date_from + const isDateToStale = + !!(temporaryFilters.date_to || dashboard?.filters.date_to) && + temporaryFilters.date_to !== dashboard?.filters.date_to + const isPropertiesStale = + !!(temporaryFilters.properties || dashboard?.filters.properties) && + JSON.stringify(temporaryFilters.properties) !== JSON.stringify(dashboard?.filters.properties) + + return isDateFromStale || isDateToStale || isPropertiesStale }, ], })),