Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surveys: Adaptive survey collection limits aren't granular enough #27115

Open
Phanatic opened this issue Dec 20, 2024 · 0 comments
Open

Surveys: Adaptive survey collection limits aren't granular enough #27115

Phanatic opened this issue Dec 20, 2024 · 0 comments

Comments

@Phanatic
Copy link
Contributor

Problem Description

The current method of allowing a user to configure adaptive survey response collection depends on a celery task that runs once every 12 hours to see if we've reached the allowed number of responses for the day.
This method doesn't guarantee that we stay under the limit of allowed responses as the response collection happens in the ingestion pipeline and there's no enforcement of any daily limits there.

The alternative here is :

  1. In posthog-js SDK, query the adaptive limits & responses received for the day and only show the survey if the responses_receveid < allowed_limit
  2. In the ingestion pipeline, discard the survey response if the survey received limit is reached for the day

#2 above is destructive and can cause customers to be confused about why they sent a survey response in, and it never showed up.

#1 is ideal in this case, since we can just hide the survey as we do with other feature flag check failures and the survey can be shown the next time the user visits the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants