Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support embedded resource manifests on Windows #560

Open
SteveL-MSFT opened this issue Sep 26, 2024 · 2 comments
Open

Support embedded resource manifests on Windows #560

SteveL-MSFT opened this issue Sep 26, 2024 · 2 comments
Labels
Milestone

Comments

@SteveL-MSFT
Copy link
Member

Summary of the new feature / enhancement

Windows exe's can have resources embedded in them so they can ship/sign just one file. dsc would need to check every exe to see if it has an embedded resource manifest, but with caching, this should only be an expensive operation the first time for resource discovery and we can invalidate specific portions of the cache if a directory's modified date changes. The embedded resource manifest would take precedence over any external file equivalent.

Proposed technical implementation details (optional)

No response

@SteveL-MSFT SteveL-MSFT added Issue-Enhancement The issue is a feature or idea Needs Triage labels Sep 26, 2024
@SteveL-MSFT SteveL-MSFT added this to the Post-3.0 milestone Sep 26, 2024
@anmenaga
Copy link
Collaborator

Need an example of an embedded resource manifest please.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Sep 26, 2024

Need an example of an embedded resource manifest please.

The file format is exactly the same, but we need to use a win32 api to retrieve it. Looks like there is at least one crate that also does this https://docs.rs/native-windows-gui/latest/native_windows_gui/struct.EmbedResource.html

Embedded resource MIGHT solve the AppStore problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants