Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script Content Triggers unhandled Newtonsoft.Json.JsonSerializationException #2165

Open
6 tasks done
Grosner300 opened this issue Jul 9, 2024 · 0 comments
Open
6 tasks done
Labels
Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed!

Comments

@Grosner300
Copy link

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with PowerShell Editor Services itself and does not reproduce in a standalone PowerShell instance, and is not an issue with my editor.
  • I have verified that I am using the latest version of PowerShell Editor Services.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

When the following code snippet is encountered in a user created PowerShell script, and the script's path is in the environment path variable, PowerShellEditorServices fails. This appears to be caused by a Newtonsoft.Json.JsonSerializationException (For additional details, see the included PowerShellEditorServices-14896.log file included below).

Because the PowerShellEditorServices is used by the PowerShell Extension for Visual Studio Code, both the extension's Command Explorer and Intellisense stop working when this exception occurs. Ideally, I feel the PowerShellEditorServices should gracefully handle and report the exception and continue running.

param ( [Parameter(Mandatory=$false)] [ValidateScript({ if ($_ -is [int] -and $_ -ge 0) { $true } else { throw "The input argument be a positive integer or zero." } })] [int]$DaysBack = 0 # Default value is 0 )

PowerShell Version

PS ~> $PSVersionTable    

Name                           Value
----                           -----
PSVersion                      7.4.3
PSEdition                      Core
GitCommitId                    7.4.3
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Editor Version

Installed PowerShell Extension for Visual Studio Code.

PowerShell Editor Services Version

N/A

Steps to Reproduce

In Windows 11:

  1. Insert aforementioned code snippet into any user defined PowerShell script.
  2. Make sure the script can be found by the PowerShellEditorServices by including its fully qualified path (not file name) in the path environment variable.
  3. Open Visual Studio Code (with the PowerShell for VS Code extension (by Microsoft) installed.
  4. Click on the PowerShell icon in the left panel, to show the Command Explorer. (You may need to enable this extension's setting: PowerShell>SideBar: Command Explorer Visibility
  5. The Command Explorer will fail to enumerate and Intellisense will stop working for PowerShell scripts.

Visuals

No response

Logs

PowerShellEditorServices-14896.log
StartEditorServices-14896.log
vscode-powershell.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug A bug to squash. Needs: Triage Maintainer attention needed!
Projects
None yet
Development

No branches or pull requests

1 participant