Add request-id response header

[ebekker]

The Classic DSC Pull Server always has a request-id header in all its responses. Presumably this is a way to tie back each request/response to some logging or tracing ability. This is a good idea and we should mimic this feature as well as message the ID in our logging and possible store it durably in any back-end store that we use to capture transactions, especially ones that produce errors.

[ebekker]

Upon closer inspection, it appears these IDs are not ephemeral and are somehow tied to a session or somehow grouping requests from the same node:

Here's a sample from RegisterDscAgent request:

HTTP/1.1 204 No Content 
Cache-Control: no-cache 
Server: Microsoft-IIS/10.0 
ProtocolVersion: 2.0 
X-Content-Type-Options: nosniff 
request-id: 93276c28-5bda-0001-b963-3093da5bd201 
DataServiceVersion: 1.0; 
X-AspNet-Version: 4.0.30319 
X-Powered-By: ASP.NET 
Date: Fri, 20 Jan 2017 11:20:37 GMT 

Here's another for SendReport requests:

HTTP/1.1 200 OK 
Cache-Control: no-cache 
Content-Type: application/json;odata=minimalmetadata;streaming=true;charset=utf-8 
Server: Microsoft-IIS/10.0 
ProtocolVersion: 2.0 
X-Content-Type-Options: nosniff 
request-id: 93276c28-5bda-0001-ba63-3093da5bd201 
DataServiceVersion: 3.0; 
X-AspNet-Version: 4.0.30319 
X-Powered-By: ASP.NET 
Date: Fri, 20 Jan 2017 11:20:37 GMT 
Content-Length: 105 
 

[ebekker]

Still more puzzling, the ID is not specific to the calling Node, here's a RegisterDscAgent from a completely different Node:

HTTP/1.1 204 No Content
Cache-Control: no-cache
Server: Microsoft-IIS/10.0
ProtocolVersion: 2.0
X-Content-Type-Options: nosniff
request-id: 93276c28-5bda-0001-8a64-3093da5bd201
DataServiceVersion: 1.0;
X-AspNet-Version: 4.0.30319
X-Powered-By: ASP.NET
Date: Fri, 20 Jan 2017 11:36:21 GMT

Here's a GetModule call from still another Node:

HTTP/1.1 200 OK 
Cache-Control: no-cache 
Content-Type: application/octet-stream 
Server: Microsoft-IIS/10.0 
ProtocolVersion: 2.0 
Prefer: return-content 
Checksum: 8FB19218B06E212F1FF251B6F8DE0B261DF3806F0FFD545090E3265A481A9716 
ChecksumAlgorithm: SHA-256 
X-Content-Type-Options: nosniff 
request-id: 93276c28-5bda-0001-8b64-3093da5bd201 
DataServiceVersion: 1.0; 
X-AspNet-Version: 4.0.30319 
X-Powered-By: ASP.NET 
Date: Fri, 20 Jan 2017 11:36:21 GMT 
Content-Length: 331673 

[ebekker]

This could actually act more like a Server ID, similar to the Agent ID which is generated every time a Node is put into pull mode.

[concentrateddon]

Yeah in all my traces I couldn't find anything consistent on that. Let me ask someone.